[mono][interp] Allow passing vtypes with a single scalar field to nat…#79686
Merged
Conversation
|
Tagging subscribers to this area: @BrzVlad Issue Details…ive code using the faster code path. This affects types like ObjectHandleOnStack which are passed to icalls.
|
Contributor
Author
|
This will hopefully fix some of the perf regressions in |
BrzVlad
reviewed
Dec 15, 2022
Contributor
Author
|
On most platforms, passing scalar vtypes is done by value, so this should work. If it doesn't, we can ifdef it for the platforms where it works. |
Contributor
Author
|
The interpreter test failures are relevant. |
Member
|
we should probably have consistency between the primitive types that are considered to be passable as a native int and the allowed types of the struct field. |
…ive code using the faster code path. This affects types like ObjectHandleOnStack which are passed to icalls.
BrzVlad
approved these changes
Dec 16, 2022
Contributor
Author
|
Failures are unrelated |
This was referenced Dec 20, 2022
Closed
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ive code using the faster code path.
This affects types like ObjectHandleOnStack which are passed to icalls.